Support NuGet packages.config - #165
Merged
Merged
Conversation
Copy our native assemblies using MSBuild when a consumer is using NuGet packages.config, since NuGet doesn't do this automatically. Also, add an error when a consumer isn't targeting x64 to tell them ML.NET only supports x64. Fix dotnet#93
eerhardt
requested review from
Ivanidzo4ka,
KrzysztofCwalina,
TomFinley and
safern
May 15, 2018 23:02
safern
approved these changes
May 16, 2018
Whoever merges this should correct this line in the commit message :) |
markusweimer
approved these changes
May 16, 2018
Member
Author
Is there an error in the line? Or is the issue just that the wording is awkward? |
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
Copy our native assemblies using MSBuild when a consumer is using NuGet packages.config, since NuGet doesn't do this automatically. Also, add an error when a project is not targeting x64. ML.NET only supports x64. Fix dotnet#93
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy our native assemblies using MSBuild when a consumer is using NuGet packages.config, since NuGet doesn't do this automatically.
Also, add an error when a consumer isn't targeting x64 to tell them ML.NET only supports x64.
Fix #93